spirv-val: Make it legal to use arrays of ray queries #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rg3igalia
force-pushed
the
ray-query-array-fix
branch
from
b3937e0
to
c0810a8
Compare
alan-baker
requested changes
Sep 19, 2022
rg3igalia
force-pushed
the
ray-query-array-fix
branch
2 times, most recently
from
56d7db3
to
9131934
Compare
alan-baker
approved these changes
Sep 19, 2022
|
Please fix the formatting errors. |
Private arrays of ray queries are legal to use. Several CTS tests check they work properly but were being rejected by spirv-val.
rg3igalia
force-pushed
the
ray-query-array-fix
branch
from
9131934
to
fc21a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private arrays of ray queries are legal to use. Several CTS tests check they work properly but were being rejected by spirv-val.
Fixes #4917.