Optimize allocation of spvtools::opt::Instruction::operands_ #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reserve space for the entire operand list rather than adding them one a time.
dneto0
approved these changes
Dec 19, 2022
| @@ -73,6 +73,7 @@ Instruction::Instruction(IRContext* c, const spv_parsed_instruction_t& inst, | |||
| unique_id_(c->TakeNextUniqueId()), | |||
| dbg_line_insts_(std::move(dbg_line)), | |||
| dbg_scope_(kNoDebugScope, kNoInlinedAt) { | |||
| operands_.reserve(inst.num_operands); | |||
There was a problem hiding this comment.
Thanks for this optimization!
We were rather lazy in the early days.
Other ideas for future: using a utils::SmallVector instead. But picking a good default size takes care. Also, it currently lacks a reserve method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserve space for the entire operand list rather than adding them one a time.