opt: fix spirv ABI on Linux again. #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking the ABI for this API isn't worth it when the fix is so simple.
airlied
force-pushed
the
opt-fix-abi-again
branch
from
fd9e3ff
to
7435784
Compare
s-perron
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking the ABI for this API isn't worth it when the fix is so simple.
81ec2aa
Author: Greg Fischer greg@lunarg.com
Date: Wed Nov 23 10:48:58 2022 -0700
in #4994 broke ABI for the library incompatibility.
Just avoid that.