instrument: Use Import linkage for instrumentation functions #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyg-lunarg
commented
Aug 1, 2023
jeremyg-lunarg
force-pushed
the
jeremyg-inst-linkage
branch
4 times, most recently
from
25e945a
to
7ae0c4a
Compare
jeremyg-lunarg
changed the title
jeremyg-lunarg
force-pushed
the
jeremyg-inst-linkage
branch
2 times, most recently
from
98be43d
to
5389112
Compare
jeremyg-lunarg
force-pushed
the
jeremyg-inst-linkage
branch
2 times, most recently
from
3841a79
to
b07c092
Compare
jeremyg-lunarg
force-pushed
the
jeremyg-inst-linkage
branch
2 times, most recently
from
9aa263a
to
55a19a8
Compare
These functions are getting far too complicated to code in SPIRV-Tools C++. Replace them with import stubs so that the real implementations can live in Vulkan-ValidationLayers where they belong. VVL will need to define these functions in spirv and link them to the instrumented version of the user's shader. From here on out, VVL can redefine the functions and any data they use without updating SPIRV-Tools. Changing the function declarations will still require both VVL and SPIRV-Tools to be updated in lock step.
jeremyg-lunarg
force-pushed
the
jeremyg-inst-linkage
branch
from
55a19a8
to
b89dda7
Compare
|
This change will break Vulkan-ValidationLayers until KhronosGroup/Vulkan-ValidationLayers#6238 merges. I'm trying to get everything all ready to go, so that the break window is minimal. And we should have far less breaking changes from here on out. |
dneto0
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are getting far too complicated to code in SPIRV-Tools C++. Replace them with import stubs so that the real implementations can live in Vulkan-ValidationLayers where they belong.
VVL will need to define these functions in spirv and link them to the instrumented version of the user's shader.
From here on out, VVL can redefine the functions and any data they use without updating SPIRV-Tools. Changing the function declarations will still require both VVL and SPIRV-Tools to be updated in lock step