add support for vulkan-shader-profiler external passes #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dneto0
reviewed
Jan 4, 2024
|
|
rjodinchr
force-pushed
the
vksp
branch
2 times, most recently
from
0f44668
to
4108da3
Compare
|
I haven't looked deeply. Requiring a depdency on vulkan-headers seems unfortunate. |
|
I have removed the dependency on vulkan-headers. |
rjodinchr
changed the title
dneto0
approved these changes
Mar 8, 2024
| @@ -511,7 +511,7 @@ const Constant* ConstantManager::GetIntConst(uint64_t val, int32_t bitWidth, | |||
| // If the value is more than 32-bit, we need to split the operands into two | |||
| // 32-bit integers. | |||
| return GetConstant( | |||
| int_type, {static_cast<uint32_t>(val >> 32), static_cast<uint32_t>(val)}); | |||
| int_type, {static_cast<uint32_t>(val), static_cast<uint32_t>(val >> 32)}); | |||
There was a problem hiding this comment.
This is the right fix.
OpConstant says
Types 32 bits wide or smaller take one word. Larger types take multiple words, with low-order words appearing first.
Too bad this wasn't caught by a unit test. I won't make you write one now.
| @@ -74,7 +74,7 @@ typedef struct spv_ext_inst_desc_t { | |||
| const uint32_t ext_inst; | |||
| const uint32_t numCapabilities; | |||
| const spv::Capability* capabilities; | |||
| const spv_operand_type_t operandTypes[16]; // TODO: Smaller/larger? | |||
| const spv_operand_type_t operandTypes[40]; // vksp needs at least 40 | |||
There was a problem hiding this comment.
These tables are pretty dumb. I'd like to refactor them for compactness.
dneto0
approved these changes
Mar 8, 2024
dneto0
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on KhronosGroup/SPIRV-Headers#398