Add preserver-interface option to spirv-opt #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimizer is able to preserve the interface variables of the shaders, but that feature has not been exposed to the command line tool. This commit adds an option `--preserve-interface` to spirv-opt that will cause all calls to ADCE to leave the input and output variables, even if the variable is unused. It will apply regardless of where the option appears on the command line. Fixes KhronosGroup#5522
|
@alecazam Let me now if this fixes your problem. I'm still trying to get input to make sure this is the right direction. To me it seems the most intuitive. |
|
That looks like it would work. To minimize code churn, could it be a member of the Optimizer class, and then you could just pull it from that. It would default to false if not set for Vulkan spirv codegen. Then you don't need the split of functions. |
|
I did it this way so I don't have to create another pass over the flags. If it is in the library then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimizer is able to preserve the interface variables of the
shaders, but that feature has not been exposed to the command line
tool.
This commit adds an option
--preserve-interfaceto spirv-opt that willcause all calls to ADCE to leave the input and output variables, even if
the variable is unused. It will apply regardless of where the option
appears on the command line.
Fixes #5522