Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-val: Add Mesh Primitive Built-In validaiton #5529

Merged

Conversation

spencer-lunarg
Copy link
Contributor

for #4919

Adds the basic built-in VUs for

  • PrimitivePointIndicesEXT
  • PrimitiveLineIndicesEXT
  • PrimitiveTriangleIndicesEXT

@alan-baker alan-baker merged commit 61c51d4 into KhronosGroup:main Feb 1, 2024
24 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-meshbuiltin2 branch February 2, 2024 00:35
@pmistryNV
Copy link
Contributor

@greg-lunarg just to confirm this commit still doesn't fix the bug #4919 .
It only adds validation support for the three builtins PrimitivePointIndicesEXT, PrimitiveLineIndicesEXT and PrimitiveTriangleIndicesEXT

@spencer-lunarg
Copy link
Contributor Author

@pmistryNV this only added

    {spv::BuiltIn::PrimitivePointIndicesEXT,  {7041, 7043, 7044}},
    {spv::BuiltIn::PrimitiveLineIndicesEXT,   {7047, 7049, 7050}},
    {spv::BuiltIn::PrimitiveTriangleIndicesEXT, {7053, 7055, 7056}},

The remaining VUs still listed in #4919 (comment)

If you search the VU in the source code you can easily find if they are added or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants