Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooling support for SPV_KHR_maximal_reconvergence #5542

Merged

Conversation

alan-baker
Copy link
Contributor

This depends on KhronosGroup/SPIRV-Headers#407. I will update the deps after it is merged.

Adds tooling support for SPV_KHR_maximal_reconvergence

  • parsing and assembly
  • validation
  • optimizer pass to add/remove the execution mode from all entry points in a module

dneto0 and others added 7 commits January 24, 2024 14:25
* Pass will add or remove execution mode from all entry points in the
  module
* Entry point references do not include the entry point
* Check for loop merge in the block was incorrect
* Check of uses was too strict
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the DEPS update to make the bots pass.
But LGTM!

source/opt/modify_maximal_reconvergence.h Outdated Show resolved Hide resolved
* Fix formatting
* Minor review change
* Fix test for header update
@alan-baker alan-baker merged commit de3d5ac into KhronosGroup:main Jan 25, 2024
24 checks passed
@sudonatalie
Copy link
Collaborator

It looks like you might have missed adding --modify-maximal-reconvergence to the help text in opt.cpp. (Just noticed when resolving merge conflicts rebasing onto this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants