[OPT] Identify arrays with unknown length in copy prop arrays #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in copy propagate arrays assumes that the length of an OpTypeArray is known at compile time, but that is not true when the size is an OpSpecConstant. We try to fix that assumption. Fixes https://crbug.com/oss-fuzz/66634
s-perron
commented
Feb 12, 2024
s-perron
commented
Feb 12, 2024
Comment on lines
+104
to
+105
| // |this| does not represent a composite type or the number of components is | ||
| // not known at compile time, the return value will be 0. |
There was a problem hiding this comment.
This changes the comment to reflect what is already done for types like OpRuntimeArray.
sudonatalie
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in copy propagate arrays assumes that the length of an
OpTypeArray is known at compile time, but that is not true when the size
is an OpSpecConstant. We try to fix that assumption.
Fixes https://crbug.com/oss-fuzz/66634