Parse -0 and -0x0 as unsigned 0 even on Mac #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around a difference between Xcode's std::istringstream and that of other platforms. Addresses part of KhronosGroup#45
|
Turns out that such cases are rejected at a higher level anyway. I'll post a different merge request to expand the test cases at the higher level instead. |
rjodinchr
pushed a commit
to rjodinchr/SPIRV-Tools
that referenced
this pull request
Jun 22, 2022
Add GroupNonUniformPartitionedNV capability to all the GroupNonUniform instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around a difference between Xcode's std::istringstream
and that of other platforms.
Addresses part of #45