More parsing tests for literals with leading minus #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also checks some hex literal cases. This addresses part of KhronosGroup#45 by removing the parseNumber case for "-0" on unsigned integers. We don't care about that platform difference at the level of std::istringstream, since we reject it at a higher parsing level.
|
|
||
| // Valid values. | ||
| EXPECT_EQ(SPV_SUCCESS, context.parseNumber("0", ec, &u32, "")); | ||
| EXPECT_EQ(0, u32); |
There was a problem hiding this comment.
Fixed in next commit
| MakeInstruction(SpvOpConstant, {1, 2, 0})})}, | ||
| {"OpTypeInt 16 1", "-32768", | ||
| Concatenate({MakeInstruction(SpvOpTypeInt, {1, 16, 1}), | ||
| MakeInstruction(SpvOpConstant, {1, 2, uint32_t(-32768)})})}, |
There was a problem hiding this comment.
"Convert arithmetic types using brace initialization."
There was a problem hiding this comment.
The style guide has been changing in this regard. That's new advice. We never did go back and change all our existing uint32_t( .. ) to static_cast. I'll use the brace initialization in future.
|
+2 despite nits. |
|
Squashed and pushed into master as feda995 |
rjodinchr
pushed a commit
to rjodinchr/SPIRV-Tools
that referenced
this pull request
Jun 22, 2022
Update Codeplay's contact details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also checks some hex literal cases.
This addresses part of
#45
by removing the parseNumber case for "-0" on unsigned
integers. We don't care about that platform difference
at the level of std::istringstream, since we reject it
at a higher parsing level.