Skip to content

Commit

Permalink
Move VkRunner tests to Amber
Browse files Browse the repository at this point in the history
CTS will use Amber as the shader test engine.
Thus this commit does:
 * move existing VkRunner tests to Amber
 * remove VkRunner from the CTS source

Affects tests:
 * dEQP-VK.graphicsfuzz.*

Components: vulkan

VK-GL-CTS issue: 1663

Change-Id: Ie3d17ec6f2eea79b777261f7c022fa7c5d0a965f
  • Loading branch information
Boris Zanin authored and alegal-arm committed Mar 29, 2019
1 parent e7a2681 commit 4698845
Show file tree
Hide file tree
Showing 34 changed files with 101 additions and 914 deletions.
5 changes: 1 addition & 4 deletions AndroidGen.mk
Expand Up @@ -58,6 +58,7 @@ LOCAL_SRC_FILES := \
external/vulkancts/framework/vulkan/vkWsiUtil.cpp \
external/vulkancts/framework/vulkan/vkYCbCrImageWithMemory.cpp \
external/vulkancts/modules/vulkan/amber/vktAmberExampleTests.cpp \
external/vulkancts/modules/vulkan/amber/vktAmberGraphicsFuzzTests.cpp \
external/vulkancts/modules/vulkan/amber/vktAmberHelper.cpp \
external/vulkancts/modules/vulkan/amber/vktAmberTestCase.cpp \
external/vulkancts/modules/vulkan/api/vktApiBufferAndImageAllocationUtil.cpp \
Expand Down Expand Up @@ -367,9 +368,6 @@ LOCAL_SRC_FILES := \
external/vulkancts/modules/vulkan/ubo/vktUniformBlockTests.cpp \
external/vulkancts/modules/vulkan/util/vktDrawUtil.cpp \
external/vulkancts/modules/vulkan/util/vktExternalMemoryUtil.cpp \
external/vulkancts/modules/vulkan/vkrunner/vktVkRunnerExampleTests.cpp \
external/vulkancts/modules/vulkan/vkrunner/vktVkRunnerGraphicsFuzzTests.cpp \
external/vulkancts/modules/vulkan/vkrunner/vktVkRunnerTestCase.cpp \
external/vulkancts/modules/vulkan/vktInfoTests.cpp \
external/vulkancts/modules/vulkan/vktShaderLibrary.cpp \
external/vulkancts/modules/vulkan/vktTestCase.cpp \
Expand Down Expand Up @@ -1110,7 +1108,6 @@ LOCAL_C_INCLUDES := \
$(deqp_dir)/external/vulkancts/modules/vulkan/texture \
$(deqp_dir)/external/vulkancts/modules/vulkan/ubo \
$(deqp_dir)/external/vulkancts/modules/vulkan/util \
$(deqp_dir)/external/vulkancts/modules/vulkan/vkrunner \
$(deqp_dir)/external/vulkancts/modules/vulkan/wsi \
$(deqp_dir)/external/vulkancts/modules/vulkan/ycbcr \
$(deqp_dir)/framework/common \
Expand Down
4 changes: 0 additions & 4 deletions CMakeLists.txt
Expand Up @@ -88,10 +88,6 @@ add_subdirectory(external/glslang)
# spirv-tools
add_subdirectory(external/spirv-tools)

# VkRunner
add_subdirectory(external/vkrunner)
include_directories(external/vkrunner/src)

# spirv-headers
set(SPIRV_INCLUDE_PATH "${PROJECT_SOURCE_DIR}/external/spirv-headers/src/include")
if (NOT EXISTS ${SPIRV_INCLUDE_PATH})
Expand Down
3 changes: 0 additions & 3 deletions android/cts/master/src/vk-excluded-tests.txt
Expand Up @@ -65,8 +65,5 @@ dEQP-VK.wsi.android.shared_presentable_image.scale_down.*
# Issue: b/67022169
dEQP-VK.wsi.android.incremental_present.scale_down.*

# Excluded VkRunner example tests
dEQP-VK.vkrunner-example.*

# Exclude Amber example tests
dEQP-VK.amber-example.*
5 changes: 0 additions & 5 deletions external/fetch_sources.py
Expand Up @@ -328,11 +328,6 @@ def postExtractLibpng (path):
None,
"d3752ea20886d2fceb6cecda3c2b146a8f22d214",
"spirv-headers"),
GitRepo(
"https://github.com/Igalia/vkrunner.git",
None,
"79229ee3662da691240bde7fb6c6578e0e10e3f1",
"vkrunner"),
GitRepo(
"https://github.com/google/amber.git",
None,
Expand Down
1 change: 0 additions & 1 deletion external/vkrunner/.gitignore

This file was deleted.

16 changes: 0 additions & 16 deletions external/vkrunner/CMakeLists.txt

This file was deleted.

117 changes: 0 additions & 117 deletions external/vulkancts/data/vulkan/vkrunner/example/spirv.shader_test

This file was deleted.

29 changes: 0 additions & 29 deletions external/vulkancts/data/vulkan/vkrunner/example/sqrt.shader_test

This file was deleted.

54 changes: 0 additions & 54 deletions external/vulkancts/data/vulkan/vkrunner/example/ubo.shader_test

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions external/vulkancts/modules/vulkan/CMakeLists.txt
Expand Up @@ -33,7 +33,6 @@ add_subdirectory(ycbcr)
add_subdirectory(protected_memory)
add_subdirectory(memory_model)
add_subdirectory(util)
add_subdirectory(vkrunner)
add_subdirectory(amber)

include_directories(
Expand Down Expand Up @@ -70,7 +69,6 @@ include_directories(
protected_memory
memory_model
util
vkrunner
amber
)

Expand Down Expand Up @@ -126,7 +124,6 @@ set(DEQP_VK_LIBS
deqp-vk-ycbcr
deqp-vk-protected-memory
deqp-vk-memory-model
deqp-vk-vkrunner
deqp-vk-amber
)

Expand Down
2 changes: 2 additions & 0 deletions external/vulkancts/modules/vulkan/amber/CMakeLists.txt
Expand Up @@ -9,6 +9,8 @@ set(DEQP_VK_AMBER_SRCS
vktAmberTestCase.cpp
vktAmberExampleTests.hpp
vktAmberExampleTests.cpp
vktAmberGraphicsFuzzTests.hpp
vktAmberGraphicsFuzzTests.cpp
)

set(DEQP_VK_AMBER_LIBS
Expand Down

0 comments on commit 4698845

Please sign in to comment.