Add tests for VK_EXT_conditional_rendering #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alegal-arm
reviewed
Oct 17, 2018
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalClearAttachmentTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalClearAttachmentTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDrawTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDrawTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDrawTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDrawTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalRenderingTestUtil.cpp
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/vulkan/conditional_rendering/VertexFetch.frag
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalRenderingTestUtil.cpp
Outdated
Show resolved
Hide resolved
werman
force-pushed
the
vulkan/VK_EXT_conditional_rendering
branch
2 times, most recently
from
b5f4264
to
4c47606
Compare
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDrawTests.cpp
Outdated
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDispatchTests.cpp
Show resolved
Hide resolved
werman
force-pushed
the
vulkan/VK_EXT_conditional_rendering
branch
from
4c47606
to
c0ea855
Compare
vkushwaha-nv
approved these changes
Oct 19, 2018
|
In the internal review now |
3 similar comments
|
In the internal review now |
|
In the internal review now |
|
In the internal review now |
alegal-arm
reviewed
Oct 30, 2018
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalRenderingTestUtil.cpp
Show resolved
Hide resolved
werman
force-pushed
the
vulkan/VK_EXT_conditional_rendering
branch
from
c0ea855
to
8890e20
Compare
jasuarez
reviewed
Oct 30, 2018
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalClearAttachmentTests.cpp
Show resolved
Hide resolved
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalDrawTests.cpp
Show resolved
Hide resolved
werman
force-pushed
the
vulkan/VK_EXT_conditional_rendering
branch
from
8890e20
to
a46acfe
Compare
jasuarez
reviewed
Oct 31, 2018
external/vulkancts/modules/vulkan/conditional_rendering/vktConditionalClearAttachmentTests.cpp
Outdated
Show resolved
Hide resolved
All functions affected by VK_EXT_conditional_rendering are tested: - vkCmdDraw, vkCmdDrawIndexed, vkCmdDrawIndirect, vkCmdDrawIndexedIndirect - vkCmdDrawIndirectCountKHR, vkCmdDrawIndexedIndirectCountKHR (VK_KHR_draw_indirect_count) - vkCmdDispatch, vkCmdDispatchIndirect, vkCmdDispatchBase - vkCmdClearAttachments The only limitation of these tests is that combination of different functions in one render pass are not tested - only several calls of the same functions. Due to the different hardware specific support of conditional rendering some implementations may have exhibit issues in such cases, especially when combining conditional rendering with functions from VK_KHR_draw_indirect_count. Components: Vulkan New Tests: dEQP-VK.conditional_rendering.* Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
werman
force-pushed
the
vulkan/VK_EXT_conditional_rendering
branch
from
a46acfe
to
2126307
Compare
|
Thank you for all your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All functions affected by VK_EXT_conditional_rendering are tested:
The only limitation of these tests is that combination of different functions in one render
pass are not tested - only several calls of the same functions. Due to the different hardware
specific support of conditional rendering some implementations may have exhibit issues in such cases,
especially when combining conditional rendering with functions from VK_KHR_draw_indirect_count.
I have run the tests on AMD GPU with Mesa and on Intel GPUs with Mesa (in this case I have tested my implementation of this extension). Unfortunately there wasn't a Windows installation in my vicinity to run the tests.