Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lunr to package.json #1238

Merged
merged 2 commits into from Jun 29, 2020
Merged

Add lunr to package.json #1238

merged 2 commits into from Jun 29, 2020

Conversation

krOoze
Copy link
Contributor

@krOoze krOoze commented Apr 9, 2020

allows to simply npm install all deps

@oddhack
Copy link
Contributor

oddhack commented Apr 9, 2020

TBH I'd like to remove this stuff. I don't know what its utility is and we very much want people to use our Docker image, or be completely responsible for their own build environment, at this point.

@krOoze
Copy link
Contributor Author

krOoze commented Apr 9, 2020

I believe lunr is something for the searchbox.

Or you mean the json? It allows to just write npm install instead of writing something annoying like npm install whatever dependency you may have. You could possibly get rid of package-lock though.

@oddhack
Copy link
Contributor

oddhack commented Apr 9, 2020

The package* files, yes.

@krOoze
Copy link
Contributor Author

krOoze commented Apr 9, 2020

Right. BTW I don't see where you are installing the he and escape-string-regexp in the docker. package.json could be still helpful to keep the dependencies organized even for the docker.

@oddhack
Copy link
Contributor

oddhack commented Apr 9, 2020

Right. BTW I don't see where you are installing the he and escape-string-regexp in the docker.

Thanks! I had forgotten to push the updated image / Dockerfile and was just running off the local cache without realizing it.

allows to simply `npm install` all deps
@oddhack oddhack merged commit ae68123 into KhronosGroup:master Jun 29, 2020
@krOoze krOoze deleted the npm_lunr branch June 29, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants