Fix VkSubpassDependency self-dependency stage VU #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddhack
reviewed
Jul 16, 2018
chapters/synchronization.txt
Outdated
| @@ -549,8 +549,9 @@ guaranteed: | |||
| * ename:VK_PIPELINE_STAGE_HOST_BIT | |||
|
|
|||
| ifdef::VK_EXT_conditional_rendering[] | |||
| For conditional rendering operations, the pipeline stage where predicate | |||
| read happens has no particular order relative to other stages. | |||
| Conditional rendering stage is considered part of the graphics, and compute | |||
There was a problem hiding this comment.
"The conditional rendering..."
There was a problem hiding this comment.
"the graphics and compute pipelines".
There was a problem hiding this comment.
I attempted some rewording here...
jeffbolznv
approved these changes
Jul 16, 2018
oddhack
added a commit
that referenced
this pull request
Aug 13, 2018
Reapply #742: Make STAGE_CONDITIONAL_RENDERING part of graphics pipe
oddhack
added a commit
that referenced
this pull request
Sep 16, 2018
Apply #742 to `VkSubpassDependency2`: allow |, allow cond. rend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix VkSubpassDependency self-dependency stage VU
ifdefinside VU entry, which e.g. breaks thevalidusage.json.