Skip to content

Commit

Permalink
Fix duplicate quotes when targets are included by downstream projects
Browse files Browse the repository at this point in the history
When trying to update the version of Vulkan-Headers used in Dawn/Tint,
I encountered errors like this:

 Target "Vulkan-Headers" contains relative path in its
  INTERFACE_INCLUDE_DIRECTORIES:

    ""/home/foo/workspace/dawn/third_party/vulkan-deps/vulkan-headers/src/include""

This PR removes the offending quotes
  • Loading branch information
zoddicus authored and juan-lunarg committed Nov 10, 2022
1 parent f97f298 commit 29c0457
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Expand Up @@ -21,11 +21,11 @@ project(Vulkan-Headers LANGUAGES C VERSION ${VK_VERSION_STRING})
message(STATUS "${PROJECT_NAME} = ${PROJECT_VERSION}")

add_library(Vulkan-Headers INTERFACE)
target_include_directories(Vulkan-Headers INTERFACE $<BUILD_INTERFACE:"${CMAKE_CURRENT_SOURCE_DIR}/include">)
target_include_directories(Vulkan-Headers INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>)
add_library(Vulkan::Headers ALIAS Vulkan-Headers)

add_library(Vulkan-Registry INTERFACE)
target_include_directories(Vulkan-Registry INTERFACE $<BUILD_INTERFACE:"${CMAKE_CURRENT_SOURCE_DIR}/registry">)
target_include_directories(Vulkan-Registry INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/registry>)
add_library(Vulkan::Registry ALIAS Vulkan-Registry)

# https://cmake.org/cmake/help/latest/variable/PROJECT_IS_TOP_LEVEL.html
Expand Down

0 comments on commit 29c0457

Please sign in to comment.