-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Allow external control of whether to test or install #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this changes the name of BUILD_TESTS, it breaks anyone's local build but also breaks the github actions CI job.
Vulkan-Headers/.github/workflows/ci.yml
Line 32 in 5ac3626
- run: cmake -S . -B build -D BUILD_TESTS=ON -G Ninja |
While I'm not sure there is a policy around the naming, the BUILD_TESTS
was consistent across other Vulkan repositories. Having a per-repo variable allows tighter control of which repo's are doing what when vendored, but it is not common for vendored repo's to want to test their dependencies.
Put another way, if you want to change the variable name, at least change all occurrences of it in the codebase.
4dc6e50
to
0072223
Compare
ac24b82
to
b62c49d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and applied the name change into ci.yml. VULKAN_HEADERS_ENABLE_TESTS is a mouthful but it is very explicit and wont be enabled by accident.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rebase and squash to make this into 1 commit. Other than that LGTM
This makes the project more composable: It can be built and tested as part of a larger set of projects, from source.
b62c49d
to
00deac0
Compare
This makes the project more composable: It can be built and tested as part of a larger set of projects, from source.