cmake: Allow external control of whether to test or install #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-lunarg
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Because this changes the name of BUILD_TESTS, it breaks anyone's local build but also breaks the github actions CI job.
Vulkan-Headers/.github/workflows/ci.yml
Line 32 in 5ac3626
While I'm not sure there is a policy around the naming, the BUILD_TESTS was consistent across other Vulkan repositories. Having a per-repo variable allows tighter control of which repo's are doing what when vendored, but it is not common for vendored repo's to want to test their dependencies.
Put another way, if you want to change the variable name, at least change all occurrences of it in the codebase.
charles-lunarg
force-pushed
the
install-test-knobs
branch
from
4dc6e50
to
0072223
Compare
ghost
reviewed
Jun 14, 2024
ghost
reviewed
Jun 14, 2024
charles-lunarg
force-pushed
the
install-test-knobs
branch
from
ac24b82
to
b62c49d
Compare
charles-lunarg
approved these changes
Jun 14, 2024
ghost
approved these changes
Jun 14, 2024
This makes the project more composable: It can be built and tested as part of a larger set of projects, from source.
charles-lunarg
force-pushed
the
install-test-knobs
branch
from
b62c49d
to
00deac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the project more composable: It can be built and tested as part of a larger set of projects, from source.