cmake: remove mingw lib prefix #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we want the dll to be named vulkan-1.dll and not libvulkan-1.dll as it is the default on mingw (for drop-in replacement)
lenny-lunarg
approved these changes
Dec 1, 2020
xantares
added a commit
to xantares/Vulkan-Loader
that referenced
this pull request
Jun 17, 2021
KhronosGroup#595 restored the default lib prefix for mingw (libvulkan-1.dll instead of vulkan-1.dl) but it changed the import lib name (libvulkan.dll.a instead of libvulkan-1.dll.a) which in turns breaks cmake detection in FindVulkan now we go back to using the default cmake prefix which is equivalent to what KhronosGroup#595 wants, (prior to KhronosGroup#523), but without the broken behavior cc @Biswa96
xantares
added a commit
to xantares/Vulkan-Loader
that referenced
this pull request
Jun 19, 2021
but it changed the import lib name (libvulkan.dll.a instead of libvulkan-1.dll.a) which in turns breaks cmake detection in FindVulkan now we go back to using the default cmake prefix which is equivalent to what KhronosGroup#595 wants, (prior to KhronosGroup#523), but without the broken behavior cc @Biswa96
xantares
added a commit
to xantares/Vulkan-Loader
that referenced
this pull request
Jun 20, 2021
but it changed the import lib name (libvulkan.dll.a instead of libvulkan-1.dll.a) which in turns breaks cmake detection in FindVulkan now we go back to using the default cmake prefix which is equivalent to what KhronosGroup#595 wants, (prior to KhronosGroup#523), but without the broken behavior cc @Biswa96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want the dll to be named vulkan-1.dll and not libvulkan-1.dll
as it is the default on mingw (for drop-in replacement)