Only return pre-instance functions when instance is NULL #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 39320. |
|
CI Vulkan-Loader build # 680 running. |
|
CI Vulkan-Loader build # 680 failed. |
charles-lunarg
force-pushed
the
disallow_global_function_getting_with_non_null_instance
branch
from
f85a8ca
to
c69b4a4
Compare
|
CI Vulkan-Loader build queued with queue ID 39329. |
|
CI Vulkan-Loader build # 681 running. |
|
CI Vulkan-Loader build # 681 failed. |
|
CI Vulkan-Loader build queued with queue ID 1126. |
|
CI Vulkan-Loader build # 758 running. |
|
CI Vulkan-Loader build # 758 failed. |
vkGetInstanceProcAddr should only return the pre-instance, aka global functions, when the VkInstance handle is NULL. This brings the desktop vulkan loader into alignment on the spec and with the android loader. KhronosGroup/Vulkan-Docs#1605 The repo previously did follow this rule, but was changes in the 1.0.42 header version timeframe for unknown reasons.
charles-lunarg
force-pushed
the
disallow_global_function_getting_with_non_null_instance
branch
from
c69b4a4
to
3da3bb4
Compare
|
CI Vulkan-Loader build queued with queue ID 1613. |
|
CI Vulkan-Loader build # 762 running. |
|
CI Vulkan-Loader build # 762 passed. |
charles-lunarg
deleted the
disallow_global_function_getting_with_non_null_instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vkGetInstanceProcAddrshould only return the pre-instance, aka globalfunctions, when the VkInstance handle is NULL. This brings the desktop
vulkan loader into alignment on the spec and with the android loader. See:
KhronosGroup/Vulkan-Docs#1605
This repo previously did follow the rule, but was changed in the
1.0.42 header version timeframe for unknown reasons.
Fixes #692