Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: Use VulkanUtilityLibrary #399

Merged
merged 1 commit into from
Apr 6, 2023
Merged

cmake: Use VulkanUtilityLibrary #399

merged 1 commit into from
Apr 6, 2023

Conversation

juan-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 51496.

1 similar comment
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 51496.

@juan-lunarg juan-lunarg mentioned this pull request Apr 5, 2023
Closed
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2461 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2461 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 51508.

1 similar comment
@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build queued with queue ID 51508.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2462 running.

@ci-tester-lunarg
Copy link
Collaborator

CI VulkanProfiles build # 2462 passed.

@juan-lunarg
Copy link
Contributor Author

Note in order to fully remove the dependency on the validation layers it looks like we need to add functionality that covers:

  • vk_layer_dispatch_table.h
  • vk_dispatch_table_helper.h
  • vk_layer_utils.h
  • vk_enum_string_helper.h

This will be a good first step in removing a dependency on the validation layers.

Thoughts?

@christophe-lunarg
Copy link
Collaborator

Note in order to fully remove the dependency on the validation layers it looks like we need to add functionality that covers:

  • vk_layer_dispatch_table.h
  • vk_dispatch_table_helper.h
  • vk_layer_utils.h
  • vk_enum_string_helper.h

This will be a good first step in removing a dependency on the validation layers.

Thoughts?

@juan-lunarg agreed!

@christophe-lunarg christophe-lunarg merged commit 85e9acc into KhronosGroup:main Apr 6, 2023
@juan-lunarg juan-lunarg deleted the juaramos/use_vul_repo branch April 6, 2023 17:06
@juan-lunarg juan-lunarg mentioned this pull request Apr 7, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophe-lunarg christophe-lunarg christophe-lunarg approved these changes

@ziga-lunarg ziga-lunarg ziga-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juan-lunarg @ci-tester-lunarg @christophe-lunarg @ziga-lunarg