Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new sample for ray tracing position fetch #1070

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Add new sample for ray tracing position fetch #1070

wants to merge 32 commits into from

Conversation

SaschaWillems
Copy link
Collaborator

Description

This PR adds a new sample for the VK_KHR_ray_tracing_position_fetch extension. It comes with a small tutorial, and shaders both for GLSL and HLSL.

Developed and tested on an nvidia RTX 4070 and Windows 11.

Important note: Requires new assets from this PR: KhronosGroup/Vulkan-Samples-Assets#26

Fixes #1004

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@SaschaWillems
Clean up api sample base class interfaces
7504395
@SaschaWillems
Revert "Clean up api sample base class interfaces"
9214e1e 
This reverts commit 7504395.
@SaschaWillems
Merge branch 'main' of https://github.com/SaschaWillems/Vulkan-Samples
6ee9bed
@SaschaWillems
Merge branch 'main' of https://github.com/SaschaWillems/Vulkan-Samples
fdc6969
@SaschaWillems
Merge branch 'main' of https://github.com/SaschaWillems/Vulkan-Samples
c93d360
@SaschaWillems
Merge branch 'main' of https://github.com/SaschaWillems/Vulkan-Samples
2705658
@SaschaWillems
Merge branch 'main' of https://github.com/SaschaWillems/Vulkan-Samples
bbf46e5
@SaschaWillems
Added sample for VK_KHR_ray_tracing_position_fetch
434c9cd 
Work-in-progress
@SaschaWillems
Added argument for passing additional buffer usage flags to glTF loading
b2b635b 
Required to access buffers in the ray tracing position fetch sample
@SaschaWillems
Fix build flags
4299a27
@SaschaWillems
Added option to add additional buffer usage flags when loading glTF s…
700f320 
…cenes
@SaschaWillems
Load full glTF scene instead of just one sub mesh
50e7606
@SaschaWillems
Offset scene and adjust camera
9657ecf
@SaschaWillems
Update HLSL shader
1e396ee
@SaschaWillems
Code cleanup
f7e3cea
@SaschaWillems
Code cleanup and simplificaiton
6ace83a 
Get buffer device addresses from buffer class
@SaschaWillems
Added new overload for adding triangle geometry to an acceleration st…
8c7092a 
…ructure

Existing function variant can't be used directly with the glTF loader
@SaschaWillems
Add display mode selection
4b8bf85
@SaschaWillems
Added sample to documentation
0bd2c6a
@SaschaWillems
Fix typo
d2d606e
@SaschaWillems
Add index type argument
4fce5b5 
Was hardcoded as UINT32, which would fail for models using different types
@SaschaWillems
Use index type from glTF mesh
9a551fd
@SaschaWillems
Added SPIR-V files for HLSL shaders
6899a53
@SaschaWillems
Add readme/tutorial
627c351
@SaschaWillems
Trying to fix clang format
97a1de2
asuessenbach
asuessenbach reviewed Jun 17, 2024
View reviewed changes
framework/api_vulkan_sample.cpp Show resolved Hide resolved
framework/core/acceleration_structure.cpp Outdated Show resolved Hide resolved
framework/gltf_loader.cpp Outdated Show resolved Hide resolved
framework/gltf_loader.cpp Outdated Show resolved Hide resolved
framework/gltf_loader.cpp Show resolved Hide resolved
samples/extensions/README.adoc Outdated Show resolved Hide resolved
samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.cpp

// Sample sepcific feature
auto &requested_ray_tracing_position_fetch_features = gpu.request_extension_features<VkPhysicalDeviceRayTracingPositionFetchFeaturesKHR>(VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_RAY_TRACING_POSITION_FETCH_FEATURES_KHR);
requested_ray_tracing_position_fetch_features.rayTracingPositionFetch = VK_TRUE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be adjusted when #1013 gets merged.

samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.cpp Outdated Show resolved Hide resolved
samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.h Show resolved Hide resolved
samples/extensions/ray_tracing_position_fetch/ray_tracing_position_fetch.h Show resolved Hide resolved
asuessenbach and others added 3 commits June 18, 2024 16:25
@asuessenbach @SaschaWillems
Port to HPPApiVulkanSample
b014de5 
Signed-off-by: Sascha Willems <webmaster@saschawillems.de>
@SaschaWillems
Fixing clang-format
b68a87a
@asuessenbach @SaschaWillems
Use vkb::core::Buffer const & in AccelerationStructure::add_triangle_…
19d1297 
…geometry.

Signed-off-by: Sascha Willems <webmaster@saschawillems.de>
gary-sweet
gary-sweet reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build ok for me and correctly reports not supported. I can't test any more than that sadly.

@jeroenbakker-atmind
Copy link
Contributor

I can test on AMD + Intel GPU this week.

@jeroenbakker-atmind
Copy link
Contributor

jeroenbakker-atmind commented Jul 2, 2024 •
edited
Loading

Works on AMD (RDNA3), Intel doesn't support this extension yet.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-sweet gary-sweet gary-sweet left review comments

@asuessenbach asuessenbach asuessenbach approved these changes

@jeroenbakker-atmind jeroenbakker-atmind jeroenbakker-atmind approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new sample for VK_KHR_ray_tracing_position_fetch
4 participants
@SaschaWillems @jeroenbakker-atmind @asuessenbach @gary-sweet