Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--data-path command line option not working #1056

Open
SRSaunders opened this issue May 28, 2024 · 1 comment
Open

--data-path command line option not working #1056

SRSaunders opened this issue May 28, 2024 · 1 comment
Labels
bug Something isn't working framework This is relevant to the framework

Comments

@SRSaunders
Copy link

SRSaunders commented May 28, 2024

It appears the --data-path command line option is not hooked up inside the code. I can successfully run the samples via the command line when my working dir is the home installation directory (i.e. Vulkan-Samples). However, if I cd to the executable dir and try to run from there using the --data-path option, the samples fail to load the shaders.

Looking at the code, --data-path does successfully set the external_storage_directory static variable inside platform.h but that's about it. When the shaders are loaded the code uses _external_storage_directory from std_filesystem.h to form the path which does not equal external_storage_directory from platform.h.

I am running on macOS, but I suspect this is also a problem on linux. Note this prevents me from using Xcode to run and debug.

@SaschaWillems
Copy link
Collaborator

Thanks for bringing this up. And yes, you're right, I guess this was broken with #894 or maybe never worked at all. We'll take a look.

@SaschaWillems SaschaWillems added bug Something isn't working framework This is relevant to the framework labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework This is relevant to the framework
Projects
None yet
Development

No branches or pull requests

2 participants