You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While unifying our framework we obviously forgot to update the template for new samples. Generating a new sample via the provided script, one gets non-working code with the template specialization for the constructor missing:
While unifying our framework we obviously forgot to update the template for new samples. Generating a new sample via the provided script, one gets non-working code with the template specialization for the constructor missing:
std::unique_ptr<vkb::VulkanSample> create_ray_tracing_position_fetch();
This now needs to be
std::unique_ptr<vkb::VulkanSample<vkb::BindingType::C>> create_ray_tracing_position_fetch();
It also looks like some stuff used in the template is no longer directly accessible, e.g. this won't compile anymore:
And should be
So we need to update our templates and in the future make sure that templates continue to work when merging framework related changes.
The text was updated successfully, but these errors were encountered: