cube: Fix layers on Apple #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise layers won't work on Apple
|
CI Vulkan-Tools build queued with queue ID 85496. |
|
CI Vulkan-Tools build # 1293 running. |
|
CI Vulkan-Tools build # 1293 passed. |
charles-lunarg
approved these changes
Nov 17, 2023
Comment on lines
-1123
to
-1132
| // Vulkan-hpp doesn't load moltenkVK, so we use volk to do that for us, then pass vkGetInstanceProcAddr along | ||
| VkResult err = volkInitialize(); | ||
| if (err != VK_SUCCESS) { | ||
| ERR_EXIT( | ||
| "Unable to find the Vulkan runtime on the system.\n\n" | ||
| "This likely indicates that no Vulkan capable drivers are installed.", | ||
| "Installation Failure"); | ||
| } | ||
|
|
||
| VULKAN_HPP_DEFAULT_DISPATCHER.init(vkGetInstanceProcAddr); |
There was a problem hiding this comment.
Good riddance to this awful hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise layers won't work on Apple