Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GNU/Hurd #996

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Add support for GNU/Hurd #996

merged 3 commits into from
Jun 5, 2024

Conversation

pinotree
Copy link
Contributor

@pinotree pinotree commented Jun 4, 2024

  • drop an useless #include (simplifies the OS porting)
  • cube: use the Unix main() also for Hurd
  • build the Linux/BSD tools also on Hurd

In case of doubts: yes, __GNU__ the official define for GNU/Hurd, see https://github.com/cpredef/predef/blob/master/OperatingSystems.md#gnu-aka-gnuhurd.

Since volk is used, this include is no more needed explicitly.
It is valid for most of the Unix platforms, including GNU/Hurd.
Enable the Linux/BSD paths that are not for Wayland also for GNU/Hurd.
@ci-tester-lunarg
Copy link

Author pinotree not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg
Copy link

Author pinotree not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, assuming this passes the CI checks, this can be merged.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build queued with queue ID 196033.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1461 running.

@ci-tester-lunarg
Copy link

CI Vulkan-Tools build # 1461 passed.

@charles-lunarg charles-lunarg merged commit 0ed7d9d into KhronosGroup:main Jun 5, 2024
19 checks passed
@pinotree pinotree deleted the hurd branch June 6, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants