Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GpuValidationArrayOOBRayTracingShaders crashes #1162

Closed
krOoze opened this issue Aug 16, 2019 · 4 comments
Closed

GpuValidationArrayOOBRayTracingShaders crashes #1162

krOoze opened this issue Aug 16, 2019 · 4 comments
Milestone

Comments

@krOoze
Copy link
Contributor

krOoze commented Aug 16, 2019

GpuValidationArrayOOBRayTracingShaders test crashes at:

ASSERT_VK_SUCCESS(vkCreateRayTracingPipelinesNV(m_device->handle(), VK_NULL_HANDLE, 1, &pipeline_ci, nullptr, &pipeline));

Deleting main body of ray generation shader makes it stop crashing, but cause the test to fail.

Also I see some invalid use:

group_create_infos[2].sType = VK_STRUCTURE_TYPE_RAY_TRACING_SHADER_GROUP_CREATE_INFO_NV;
group_create_infos[2].type = VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_NV;
group_create_infos[2].generalShader = VK_SHADER_UNUSED_NV;
group_create_infos[2].closestHitShader = 2;
group_create_infos[2].anyHitShader = 1;
group_create_infos[2].intersectionShader = 4;

group_create_infos[3].sType = VK_STRUCTURE_TYPE_RAY_TRACING_SHADER_GROUP_CREATE_INFO_NV;
group_create_infos[3].type = VK_RAY_TRACING_SHADER_GROUP_TYPE_TRIANGLES_HIT_GROUP_NV;
group_create_infos[3].generalShader = 5; // call

@TonyBarbour
Copy link
Contributor

Is this a new crash? Was it working before? What is your system configuration?

When we were testing #1052 we had to update our driver to avoid an access violation in the Nvidia driver. 425.88 is working for us here with this morning's master. Could the driver be your problem?

I would agree that those are both invalid usages and are not checked for in current validation code. @jmacnak-nv would the fix be as simple as setting the offending shaders to UNUSED?

@krOoze
Copy link
Contributor Author

krOoze commented Aug 16, 2019

I have been ignoring it for a while. I think it is crashing for at least two weeks.

Crashes on NV GTX 1060 6 GB 431.60 DCH Game-optimized, Win 10 1903. Crashes inside driver dlls.

@jeffbolznv
Copy link
Contributor

Eric tested this internally and said the crash in the driver is resolved in the next driver release, but it sounds like there may be some invalid usage here to resolve nonetheless.

@krOoze
Copy link
Contributor Author

krOoze commented Aug 20, 2019

Indeed, new driver works.

mark-lunarg pushed a commit that referenced this issue Aug 20, 2019
Corrects the VkRayTracingShaderGroupTypeNV field for two shader groups:
- shader group 2 should be PROCEDURAL_HIT since the geometry is AABBs
- shader group 3 should be GENERAL since the group is for a callable

Addresses usage concerns reported in
#1162

Tested on laptop with GTX1060 and Nvidia's 436.02 game ready driver.
@krOoze krOoze closed this as completed Aug 20, 2019
@shannon-lunarg shannon-lunarg added this to the sdk-1.1.121.0 milestone Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants