-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GpuValidationArrayOOBRayTracingShaders crashes #1162
Comments
Is this a new crash? Was it working before? What is your system configuration? When we were testing #1052 we had to update our driver to avoid an access violation in the Nvidia driver. 425.88 is working for us here with this morning's master. Could the driver be your problem? I would agree that those are both invalid usages and are not checked for in current validation code. @jmacnak-nv would the fix be as simple as setting the offending shaders to UNUSED? |
I have been ignoring it for a while. I think it is crashing for at least two weeks. Crashes on NV GTX 1060 6 GB 431.60 DCH Game-optimized, Win 10 1903. Crashes inside driver dlls. |
Eric tested this internally and said the crash in the driver is resolved in the next driver release, but it sounds like there may be some invalid usage here to resolve nonetheless. |
Indeed, new driver works. |
Corrects the VkRayTracingShaderGroupTypeNV field for two shader groups: - shader group 2 should be PROCEDURAL_HIT since the geometry is AABBs - shader group 3 should be GENERAL since the group is for a callable Addresses usage concerns reported in #1162 Tested on laptop with GTX1060 and Nvidia's 436.02 game ready driver.
GpuValidationArrayOOBRayTracingShaders
test crashes at:Vulkan-ValidationLayers/tests/vklayertests_descriptor_renderpass_framebuffer.cpp
Line 1291 in 22a1c99
Deleting
main
body of ray generation shader makes it stop crashing, but cause the test to fail.Also I see some invalid use:
Vulkan-ValidationLayers/tests/vklayertests_descriptor_renderpass_framebuffer.cpp
Lines 1267 to 1272 in 22a1c99
Vulkan-ValidationLayers/tests/vklayertests_descriptor_renderpass_framebuffer.cpp
Lines 1274 to 1276 in 22a1c99
The text was updated successfully, but these errors were encountered: