Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect test in vkCreateDevice() best practices #1274

Merged
merged 3 commits into from Sep 23, 2019
Merged

Fix incorrect test in vkCreateDevice() best practices #1274

merged 3 commits into from Sep 23, 2019

Conversation

cdwfs
Copy link
Contributor

@cdwfs cdwfs commented Sep 20, 2019

  • Add state tracking for vkGetPhysicalDeviceFeatures*() variants
  • Test correct state in vkCreateDevice() best-practices check

Fixes #1272

@mark-lunarg mark-lunarg self-assigned this Sep 20, 2019
@mark-lunarg mark-lunarg added the Bug Something isn't working label Sep 20, 2019
@mark-lunarg mark-lunarg added this to the P1 milestone Sep 20, 2019
@cdwfs cdwfs force-pushed the cort-vkgetphysicaldevicefeatures-state branch from 990e731 to 9250a96 Compare September 20, 2019 21:15
@mark-lunarg mark-lunarg merged commit ffba264 into KhronosGroup:master Sep 23, 2019
@cdwfs cdwfs deleted the cort-vkgetphysicaldevicefeatures-state branch September 23, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-lunarg mark-lunarg mark-lunarg approved these changes

Assignees

@mark-lunarg mark-lunarg

Labels
Bug Something isn't working
Projects
None yet
Milestone
P1
Development

Successfully merging this pull request may close these issues.

vkCreateDevice "best practices" check is testing the wrong state
2 participants
@cdwfs @mark-lunarg