layers: Move state tracker methods to CMD_BUFFER_STATE #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving these methods requires a back pointer to the state tracker in the command buffer objects for doing handle lookups.
|
CI Vulkan-ValidationLayers build queued with queue ID 17169. |
|
CI Vulkan-ValidationLayers build # 4341 running. |
|
CI Vulkan-ValidationLayers build # 4341 passed. |
jeremyg-lunarg
requested review from
ncesario-lunarg,
TonyBarbour,
jzulauf-lunarg and
ziga-lunarg
|
FYI @nadavgevaAMD |
Merged
ncesario-lunarg
approved these changes
Aug 12, 2021
| } | ||
|
|
||
| void CMD_BUFFER_STATE::Destroy() { | ||
| // Allow any derived class to clean up command buffer state | ||
| if (dev_data->command_buffer_reset_callback) { | ||
| (*dev_data->command_buffer_reset_callback)(commandBuffer()); |
There was a problem hiding this comment.
Any luck with removing these callbacks from state tracker? Or perhaps it doesn't make sense to do so?
There was a problem hiding this comment.
That is coming in a follow on PR. I have it working in a local build.
|
LGTM -- though with code movement changes, hard to assess. Recommend additional testing (CTS/perf traces). |
|
This went through perf and error count vvltraces runs last night without regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving these methods requires a back pointer to the state
tracker in the command buffer objects for doing handle lookups.