Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layers: Stomp old values in ValidationStateTracker::Add() #3501

Merged

Conversation

jeremyg-lunarg
Copy link
Contributor

@jeremyg-lunarg jeremyg-lunarg commented Nov 4, 2021

Make sure we clear out any old values in the map in Add().
Since this is likely a bug in the state tracker if it happens,
assert if the entry is an overwrite.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 12002.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5411 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5411 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 12080.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5412 running.

Make sure we clear out any old values in the map in Add().
Since this is likely a bug in the state tracker if it happens,
assert if the entry is an overwrite.
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 12090.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5413 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 5413 passed.

Copy link
Contributor

@TonyBarbour TonyBarbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and found GPU-AV problem

@jeremyg-lunarg jeremyg-lunarg merged commit 208c06c into KhronosGroup:master Nov 4, 2021
@jeremyg-lunarg jeremyg-lunarg deleted the jeremyg-stompy-add branch November 4, 2021 21:59
Copy link
Contributor

@ncesario-lunarg ncesario-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants