layers: Only support shared_ptr Get<>() methods #3575
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 7421. |
|
CI Vulkan-ValidationLayers build # 5608 running. |
|
CI Vulkan-ValidationLayers build # 5608 failed. |
jeremyg-lunarg
force-pushed
the
jeremyg-get-shared
branch
from
c0e01c0
to
0de61ae
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 7893. |
|
CI Vulkan-ValidationLayers build # 5622 running. |
|
CI Vulkan-ValidationLayers build # 5622 passed. |
jeremyg-lunarg
force-pushed
the
jeremyg-get-shared
branch
from
0de61ae
to
ac82a75
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 8135. |
|
CI Vulkan-ValidationLayers build # 5629 running. |
|
CI Vulkan-ValidationLayers build # 5629 passed. |
jeremyg-lunarg
requested review from
ncesario-lunarg,
jzulauf-lunarg,
TonyBarbour and
ziga-lunarg
| @@ -3584,18 +3589,18 @@ bool CoreChecks::ValidateCmdResolveImage(VkCommandBuffer commandBuffer, VkImage | |||
| bool skip = false; | |||
| if (cb_node && src_image_state && dst_image_state) { | |||
| vuid = is_2khr ? "VUID-VkResolveImageInfo2KHR-srcImage-00256" : "VUID-vkCmdResolveImage-srcImage-00256"; | |||
| skip |= ValidateMemoryIsBoundToImage(src_image_state, func_name, vuid); | |||
| skip |= ValidateMemoryIsBoundToImage(src_image_state.get(), func_name, vuid); | |||
There was a problem hiding this comment.
Would it make sense to first refactor functions like this to take a reference? Seems like that might make this change a lot smaller, and the use of operator* could avoid future churn between smart-pointer <-> pointer refactors in the future.
That could also be done as a post-refactor, though.
There was a problem hiding this comment.
yes, I tried to start doing that and quickly realized it would make this patch 2x - 3x bigger so I stopped. for now...
In order to make it feasible to use reduced locking in the validation layers, it will be necessary for the validation code to hold a reference count on any state objects that are being used. Copying shared_ptr's involves atomic operations and is more expensive than copying raw pointers, so it should be avoided if possible. Some guidelines: -Avoid repeated Get<> calls whenever possible. These are a hash lookup, shared_ptr<> copy, and (eventually) map locking operations. -Functions that use a state object but don't change ownership should pass by reference (preferred) or raw pointer. 'void func(Foo &);' or 'void func(Foo *);' -Functions that share ownership (caller keeps reference and callee takes an addiional reference) should pass a shared_ptr lvalue reference `void func(shared_ptr<Foo>&).` This avoids a useless shared pointer copy for the function argument. -Functions that transfer ownership (caller gives up reference and callee takes it) should pass a shared_ptr rvalue reference `void func2(shared_ptr<Foo> &&);` This allows std::move() to be used to avoid shared_ptr copies.
jeremyg-lunarg
force-pushed
the
jeremyg-get-shared
branch
from
ac82a75
to
d0b663d
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 12874. |
|
CI Vulkan-ValidationLayers build # 5679 running. |
|
CI Vulkan-ValidationLayers build # 5679 passed. |
In order to make it feasible to use reduced locking in the validation
layers, it will be necessary for the validation code to hold a
reference count on any state objects that are being used.
Copying shared_ptr's involves atomic operations and is more expensive
than copying raw pointers, so it should be avoided if possible.
Some guidelines:
-Avoid repeated Get<> calls whenever possible. These are a hash lookup,
shared_ptr<> copy, and (eventually) map locking operations.
-Functions that use a state object but don't change ownership should
pass by reference (preferred) or raw pointer.
void func(Foo &);orvoid func(Foo *);-Functions that share ownership (caller keeps reference and callee takes
an addiional reference) should pass a shared_ptr lvalue reference
void func(shared_ptr<Foo>&).This avoids a useless shared pointercopy for the function argument.
-Functions that transfer ownership (caller gives up reference and callee
takes it) should pass a shared_ptr rvalue reference
void func2(shared_ptr<Foo> &&);This allows std::move() to be usedto avoid shared_ptr copies.