layers: Clean up result variable declarations for GetRead<>(), GetWrite<>(), Get<>() and shared_ptr<>.get() #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods return a LockedSharedPtr<> that holds a pointer of the appropriate constness. Adding const to the return value declaration makes the returned object const, which is irrelevant.
These methods return a shared_ptr<> that holds a pointer of the appropriate constness. Adding const to the return value declaration makes the returned object const, which is irrelevant.
This method returns a raw pointer that should be marked appropriately.
|
CI Vulkan-ValidationLayers build queued with queue ID 3288. |
|
CI Vulkan-ValidationLayers build # 6086 running. |
|
CI Vulkan-ValidationLayers build # 6086 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GetRead<>, GetWrite<> and Get<>, adding const to the return value declaration makes the returned pointer object const, which is irrelevant. The pointer held by the object should already have the appropriate constness.
But shared_ptr<>.get() returns a raw pointer that should have 'const' and / or '*' in the declaration for a variable holding its result.
This was raised as a problem in PR #3659