Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf: Remove stage specific information #7062

Merged
merged 2 commits into from
Dec 5, 2023
Merged

printf: Remove stage specific information #7062

merged 2 commits into from
Dec 5, 2023

Conversation

jeremyg-lunarg
Copy link
Contributor

Remove stage specific debug info that is only needed by GPU-AV. This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes #4350

@jeremyg-lunarg jeremyg-lunarg requested a review from a team as a code owner December 1, 2023 23:01
@jeremyg-lunarg jeremyg-lunarg marked this pull request as draft December 1, 2023 23:01
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 93431.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14728 running.

TonyBarbour
TonyBarbour approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@TonyBarbour TonyBarbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14728 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 94798.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14751 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14751 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 94925.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14759 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14759 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 95067.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14763 running.

@jeremyg-lunarg
printf: Remove stage specific information
b874671 
Remove stage specific debug info that is only needed by GPU-AV.
This allows debug printfs to be used in multi stage shader modules.

Requires KhronosGroup/SPIRV-Tools#5495

Fixes KhronosGroup#4350

Also includes the VUL linking change from KhronosGroup#7050
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 95095.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14765 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14765 failed.

@jeremyg-lunarg
tests: Disable tests that new SPIRV-Tools think are invalid
6652a95 
NegativeShaderCompute.WorkgroupMemoryExplicitLayout
NegativeShaderLimits.OffsetMaxComputeSharedMemorySize
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 95233.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14769 running.

@jeremyg-lunarg jeremyg-lunarg marked this pull request as ready for review December 5, 2023 03:56
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 14769 passed.

@jeremyg-lunarg jeremyg-lunarg merged commit 57cb6ce into KhronosGroup:main Dec 5, 2023
19 checks passed
@jeremyg-lunarg jeremyg-lunarg deleted the jeremyg-printf-stage branch December 5, 2023 15:48
@jeremyg-lunarg jeremyg-lunarg mentioned this pull request Dec 5, 2023
Closed
@spencer-lunarg spencer-lunarg mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyBarbour TonyBarbour TonyBarbour approved these changes

@arno-lunarg arno-lunarg arno-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug printf reports "Mixed stage shader module not supported"
4 participants
@jeremyg-lunarg @ci-tester-lunarg @TonyBarbour @arno-lunarg