Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layers: Rework shader variable access logic #8058

Merged
merged 3 commits into from
May 29, 2024
Merged

layers: Rework shader variable access logic #8058

merged 3 commits into from
May 29, 2024

Conversation

spencer-lunarg
Copy link
Contributor

the is_written_to/is_read_from was a lie and never worked

This adds proper support to know if the variable is actually accessed. This is important for many upcoming SPIR-V related changes

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner May 26, 2024 17:17
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 191712.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16686 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16686 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 191738.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16687 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16687 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 191811.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16690 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16690 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 191836.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16691 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16691 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 191918.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16692 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16692 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 192312.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16696 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16696 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 192683.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16699 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 16699 passed.

artem-lunarg
artem-lunarg approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@artem-lunarg artem-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To be honest don't understand all details but checked general structure and trust the expertise of the author.

@spencer-lunarg spencer-lunarg merged commit e15fdd0 into KhronosGroup:main May 29, 2024
21 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-store branch May 29, 2024 15:43
This was referenced Jun 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filnet filnet filnet left review comments

@artem-lunarg artem-lunarg artem-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spencer-lunarg @ci-tester-lunarg @filnet @artem-lunarg