tests: Add support for regex lookup in error msg #8187
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 205964. |
arno-lunarg
force-pushed
the
arno-tests-regex
branch
from
2249a6b
to
988450b
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 205978. |
|
CI Vulkan-ValidationLayers build # 16909 running. |
arno-lunarg
force-pushed
the
arno-tests-regex
branch
from
988450b
to
4168ace
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 206007. |
|
CI Vulkan-ValidationLayers build # 16910 failed. |
1 similar comment
|
CI Vulkan-ValidationLayers build # 16910 failed. |
| m_errorMonitor->SetDesiredError("VUID-vkCmdDrawIndirectCount-countBuffer-03122"); | ||
| m_errorMonitor->SetDesiredErrorRegex( | ||
| "VUID-vkCmdDrawIndirectCount-countBuffer-03122", | ||
| "Indirect draw count of 2 would exceed buffer size 16 of buffer VkBuffer 0x[a-f0-9]*\\[\\] stride = 16 offset = 0 " |
There was a problem hiding this comment.
will be fun copying 0x[a-f0-9]*\\[\\] all over 😆
There was a problem hiding this comment.
oh I left that... honestly 0x[a-f0-9]*\\[\\] could just be .*
There was a problem hiding this comment.
... that would feel nicer in my soul to copy in the future
arno-lunarg
force-pushed
the
arno-tests-regex
branch
from
4168ace
to
9cbdc0d
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 206352. |
|
CI Vulkan-ValidationLayers build # 16917 running. |
|
CI Vulkan-ValidationLayers build # 16917 failed. |
arno-lunarg
force-pushed
the
arno-tests-regex
branch
from
9cbdc0d
to
7736ee2
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 206408. |
|
CI Vulkan-ValidationLayers build # 16919 running. |
|
CI Vulkan-ValidationLayers build # 16919 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 206448. |
|
CI Vulkan-ValidationLayers build # 16921 running. |
|
CI Vulkan-ValidationLayers build # 16921 passed. |
For now only tried it in NegativeGpuAVIndirectBuffer.DrawCount
arno-lunarg
force-pushed
the
arno-tests-regex
branch
from
7736ee2
to
1415fe0
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 206584. |
|
CI Vulkan-ValidationLayers build # 16928 running. |
1 similar comment
|
CI Vulkan-ValidationLayers build # 16928 running. |
|
CI Vulkan-ValidationLayers build # 16928 passed. |
| @@ -149,6 +165,12 @@ void ErrorMonitor::SetDesiredError(const char *msg, uint32_t count) { | |||
| } | |||
| } | |||
|
|
|||
| void ErrorMonitor::SetDesiredErrorRegex(const char *vuid, std::string msg_regex, uint32_t count /*= 1*/) { | |||
| for (uint32_t i = 0; i < count; i++) { | |||
| SetDesiredFailureMsgRegex(kErrorBit, vuid, msg_regex); | |||
There was a problem hiding this comment.
if count is greater than one then you might end up "compiling" the regex string multiple times.
There was a problem hiding this comment.
yes, I agree, will take a look later, for the short term, most things use count of 1 and the few GPU-AV tests that use it is 3 so we shouldn't accidentally hit a crazy regex compiling bottleneck, but I always monitor how long tests take to run regardless, so good thing to note as a possible spot to look at
There was a problem hiding this comment.
nvm, @arno-lunarg is a better man than me #8206
Proposal for #8140
For now only tried it in NegativeGpuAVIndirectBuffer.DrawCount