build: Fix GN build for JSON_LAYER_NAME #8188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 206026. |
artem-lunarg
approved these changes
Jun 24, 2024
spencer-lunarg
force-pushed
the
spencer-lunarg-gn-fix
branch
from
bcdc842
to
fe20ad9
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 206038. |
|
CI Vulkan-ValidationLayers build # 16912 passed. |
1 similar comment
|
CI Vulkan-ValidationLayers build # 16912 passed. |
|
Thanks, seem like this fixed it https://chromium-review.googlesource.com/c/angle/angle/+/5650184. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a fix for #8185 (comment)
@y-novikov if you want to try this