Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance copyTexImage2D / copyTexSubImage2D tests #3255

Closed
kenrussell opened this issue Mar 9, 2021 · 2 comments
Closed

Enhance copyTexImage2D / copyTexSubImage2D tests #3255

kenrussell opened this issue Mar 9, 2021 · 2 comments

Comments

@kenrussell
Copy link
Member

A bug reported by the Three.js developers against WebKit:
https://bugs.webkit.org/show_bug.cgi?id=222790

demonstrated that the tests of copyTexImage2D and copyTexSubImage2D are likely incomplete. The failure that was reported was only caught by WebKit-specific tests.

The associated tests in the WebGL conformance suite - likely conformance/textures/misc/copy-tex-image-and-sub-image-2d.html - should be updated.

@kimmok
Copy link

kimmok commented Mar 9, 2021

I think the test is good and should have caught the problem, it's a webkit test infra bug that this wasn't caught.
Can be closed.

@kenrussell
Copy link
Member Author

OK, thanks for your feedback. I re-reviewed https://bugs.webkit.org/show_bug.cgi?id=222790 and it's not 100% clear to me that all of the cases in the revised test are covered by sdk/tests/conformance/textures/misc/copy-tex-image-and-sub-image-2d.html , but will take your word for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants