Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = None #3343

Open
kkinnunen-apple opened this issue Oct 11, 2021 · 0 comments

Comments

@kkinnunen-apple
Copy link
Contributor

kkinnunen-apple commented Oct 11, 2021

texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = None

explained by @greggman in related but orthogonal issue #3341:

When UNPACK_COLORSPACE_CONVERSION_WEBGL = true there ZERO guarantee of anything whatsoever. The browser stuffs whatever data it has into the texture as is. Some browsers might have applied color space, they might have applied a display profile, they might have applied anything. They may or may not support the various ways of specifying a color space in the file itself. That's undefined just like it's undefined what formats a browser supports (gif? jpg? webp? animated png? jpeg2000? tiff? not sure if Safari still supports tiff but it did at one time and no other browser did) it's also undefined what details of a file format a browser supports. For example it might ignore png color spaces just like many browsers ignored animated png files for a long time.

(With true == BROWSER_DEFAULT_WEBGL and false == None)

Given following facts

  1. Using UNPACK_COLORSPACE_CONVERSION_WEBGL = BROWSER_DEFAULT_WEBGL, the pixel values are undefined
  2. The test uses UNPACK_COLORSPACE_CONVERSION_WEBGL = BROWSER_DEFAULT_WEBGL
  3. The test asserts specific defined pixel values

Sounds like a contradiction?

Maybe the test could use UNPACK_COLORSPACE_CONVERSION_WEBGL = None ?

@kkinnunen-apple kkinnunen-apple changed the title texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = false texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = None Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant