You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = None
explained by @greggman in related but orthogonal issue #3341:
When UNPACK_COLORSPACE_CONVERSION_WEBGL = true there ZERO guarantee of anything whatsoever. The browser stuffs whatever data it has into the texture as is. Some browsers might have applied color space, they might have applied a display profile, they might have applied anything. They may or may not support the various ways of specifying a color space in the file itself. That's undefined just like it's undefined what formats a browser supports (gif? jpg? webp? animated png? jpeg2000? tiff? not sure if Safari still supports tiff but it did at one time and no other browser did) it's also undefined what details of a file format a browser supports. For example it might ignore png color spaces just like many browsers ignored animated png files for a long time.
(With true == BROWSER_DEFAULT_WEBGL and false == None)
Given following facts
Using UNPACK_COLORSPACE_CONVERSION_WEBGL = BROWSER_DEFAULT_WEBGL, the pixel values are undefined
The test uses UNPACK_COLORSPACE_CONVERSION_WEBGL = BROWSER_DEFAULT_WEBGL
The test asserts specific defined pixel values
Sounds like a contradiction?
Maybe the test could use UNPACK_COLORSPACE_CONVERSION_WEBGL = None ?
The text was updated successfully, but these errors were encountered:
kkinnunen-apple
changed the title
texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = false
texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = None
Oct 11, 2021
texture-corner-cases-video does not use UNPACK_COLORSPACE_CONVERSION_WEBGL = None
explained by @greggman in related but orthogonal issue #3341:
(With true == BROWSER_DEFAULT_WEBGL and false == None)
Given following facts
UNPACK_COLORSPACE_CONVERSION_WEBGL = BROWSER_DEFAULT_WEBGL
, the pixel values are undefinedUNPACK_COLORSPACE_CONVERSION_WEBGL = BROWSER_DEFAULT_WEBGL
Sounds like a contradiction?
Maybe the test could use
UNPACK_COLORSPACE_CONVERSION_WEBGL = None
?The text was updated successfully, but these errors were encountered: