Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream unused uniform fixes to ES 3.0 suite, make harness stricter #390

Open
kenrussell opened this issue Oct 4, 2013 · 0 comments
Open

Comments

@kenrussell
Copy link
Member

In #340 the WebGL conformance suite harness for running the imported ES 3.0 tests was relaxed to be identically as strict as ES 3.0's GTF harness, because of problems with unreferenced uniforms being optimized away by some GLSL compilers. This was an expedient workaround for allowing the WebGL 1.0.2 conformance suite to be passed.

A better fix would be to fix the tests and make the ES 3.0 conformance suite harness stricter, requiring that all referenced uniforms be present. At that point the WebGL harness should me made stricter as well.

This is a follow-on to Issue 236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant