Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add or update per-file licenses #435

Closed
kenrussell opened this issue Dec 4, 2013 · 4 comments
Closed

Add or update per-file licenses #435

kenrussell opened this issue Dec 4, 2013 · 4 comments

Comments

@kenrussell
Copy link
Member

The WebGL repository is now being pulled wholesale into the Chromium repository for testing purposes. Chromium requires that all third-party files pass the Linux licensecheck utility. Currently many files in the WebGL repository fail this check, either because of missing or unrecognized per-file licenses.

A separate bug regarding the html5lib library has been filed at html5lib/html5lib-python#125 . The complete list of files failing licensecheck follows. Ideally all of these files will be fixed.

'third_party/webgl/src/sdk/demos/google/san-angeles/gles/bob/compare.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/build.sh' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/include/GLES/egltypes.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/include/GLES/egl.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/include/GLES/gl.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/t/app-linux.c' has non-whitelisted license 'MIT/X11 (BSD like) LGPL (v2.1 or later)'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/build.sh' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/include/GLES/egltypes.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/include/GLES/egl.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/include/GLES/gl.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/gles/app-linux.c' has non-whitelisted license 'MIT/X11 (BSD like) LGPL (v2.1 or later)'
'third_party/webgl/src/sdk/demos/google/san-angeles/glut/app-glut.c' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/glut/build.sh' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/glut/include/GLES/egltypes.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/glut/include/GLES/egl.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/glut/include/GLES/gl.h' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/sdk/demos/google/san-angeles/glut/app-linux.c' has non-whitelisted license 'MIT/X11 (BSD like) LGPL (v2.1 or later)'
'third_party/webgl/src/sdk/demos/google/nvidia-vertex-buffer-object/VertexBufferObject2.java' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/specs/1.0/extract-idl.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/specs/latest/1.0/extract-idl.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/specs/latest/2.0/extract-idl.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/specs/1.0.2/extract-idl.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/index.php' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/inputstream.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/html5parser.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/pulldom.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/etree.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/lxmletree.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/init.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/soup.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/dom.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/_base.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/simpletree.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treewalkers/genshistream.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/sanitizer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/ihatexml.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/inject_meta_charset.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/lint.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/sanitizer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/optionaltags.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/_base.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/whitespace.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/filters/formfiller.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/etree.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/etree_lxml.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/init.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/soup.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/dom.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/_base.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/treebuilders/simpletree.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/utils.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_stream.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/runparsertests.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_treewalkers.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/tokenizertotree.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_sanitizer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_serializer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_whitespace_filter.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/init.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_encoding.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_formfiller.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/support.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_tokenizer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/test_parser.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/performance/concatenation.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/runtests.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tests/mockParser.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/serializer/htmlserializer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/serializer/xhtmlserializer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/serializer/init.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/init.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/constants.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/resources/html5lib/src/html5lib/tokenizer.py' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/extensions/atom.xsl' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/extensions/schematron/iso_dsdl_include.xsl' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/extensions/schematron/webgl_message_patch.xsl' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/extensions/schematron/iso_svrl_for_xslt1.xsl' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/extensions/standards.xsl' has non-whitelisted license 'UNKNOWN'
'third_party/webgl/src/extensions/rev_utils.xsl' has non-whitelisted license 'UNKNOWN'
@grorg
Copy link
Contributor

grorg commented Dec 4, 2013

Is it ok to add the Khronos license to all the non-html5lib files?

@kenrussell
Copy link
Member Author

No, more care is needed than that.

It would be OK to do this for index.php, all copies of extract-idl.py, and maybe the files in extensions/ -- I don't know about the latter. Should check with David Sheets, who contributed those.

The stuff under the san-angeles directory is problematic because it's a verbatim copy of sources that live elsewhere. We can't touch those files.

I ported VertexBufferObject2.java from C++ to Java a long time ago. The NVIDIA license seems liberal enough but probably doesn't match anything in the licensecheck utility.

Taking care of our files would be great -- any help would be appreciated. I didn't expect this bug would be fixed and closed quickly, though.

@kdashg
Copy link
Contributor

kdashg commented Sep 25, 2019

@kenrussell Is this still relevant?

@kenrussell
Copy link
Member Author

Let's close this. These files were whitelisted in Chromium some time ago and it would be a lot of work to chase down licenses in these files for unclear benefit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grorg @kenrussell @kdashg