Hide the model that has > 4 jointweights per vertex #469
Conversation
… clearer on this case
|
|
||
| properties.Add(new Property(PropertyName.Description, "`skinF`.")); | ||
| }, (model) => { model.Camera = distantCamera; }), | ||
| //CreateModel((properties, animations, nodes) => { |
There was a problem hiding this comment.
Would be good to put a comment before this saying why this is commented out.
I think the spec is fairly clear — most engines don't support >4, and the spec mentions that. Any particular details to add? |
Do you mean this?
I couldn't find anywhere that says most engines don't support >4. Currently, all of the test assets we have are positive tests meaning they are supposed to work everywhere. I don't think we should include a test with more than one set of joints/weights unless we somehow mark them. |
|
@stevk mentioned to me that the spec has this: https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#skinned-mesh-attributes
The issue with this is that we are saying we need a test model here: KhronosGroup/glTF#1403 The >4 issue is here: KhronosGroup/glTF#1381 The question for me is whether a model with >4 joints/weights per vertex is a positive test or a negative test. |
None of the clients that have setup previews work with this model. Hiding it for now, since the spec doesn't have an explicit direction on how this case should be handled.