Export: workaround for #932 #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the workaround added by f2f3b83. Sometimes calling gather_material invalidates the blender_mesh being used by gather_mesh. This just swaps the order of gather_primitives and gather_weights. The blender_mesh is now never accessed again after gather_material is called.
emackey
approved these changes
Mar 5, 2020
|
/cc #962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a really simple workaround for #932.
We know the problem is accessing blender_mesh in gather_weights after calling gather_material from gather_primitives. So this just swaps the order of gather_weights and gather_primitives. Now blender_mesh is never accessed again after calling gather_material.
Removes the workaround from f2f3b83 so weights will get gathered again.