Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glTF-projects-data.json #56

Closed
wants to merge 1 commit into from

Conversation

MonaliProtoTech
Copy link
Contributor

@MonaliProtoTech MonaliProtoTech commented Jun 22, 2020

Prototech GLTF exporters.

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2020

CLA assistant check
All committers have signed the CLA.

@MonaliProtoTech
Copy link
Contributor Author

Prototech GLTF Exporters.

@MonaliProtoTech
Copy link
Contributor Author

ProtoTech GLTF Exporters for different CAD platforms.

@javagl
Copy link
Contributor

javagl commented Jun 22, 2020

Thanks for your contribution.

There had been (a merge conflict with another PR, but more importantly) some formatting errors in the JSON, e.g. missing "quotation marks" around links and such.

So I have added the projects manually in another PR, namely #57 , and also merged it, and the update should be visible on the project explorer page soon.

@javagl javagl closed this Jun 22, 2020
@MonaliProtoTech
Copy link
Contributor Author

MonaliProtoTech commented Jun 29, 2020 via email

@javagl
Copy link
Contributor

javagl commented Jun 29, 2020

The deployment should largely be automated, but indeed, the latest change does not seem to appear yet.

@weegeekps The previous change seemed to have become visible in the online version automatically, but the most recent one doesn't seem to appear. I think that you once wrote a few hints about the deployment (or how to trigger it manually), but haven't found it right now. If you give me a short hint or pointer, I'd (try to) add some information to a DEPLOYMENT.md or so...

@MonaliProtoTech
Copy link
Contributor Author

MonaliProtoTech commented Jun 29, 2020 via email

@javagl
Copy link
Contributor

javagl commented Jun 29, 2020

The information has been added with this commit: f0a8687

It should be visible on the Project Explorer website soon. I just had to ask @weegeekps to find out what has to be done so that these new entries appear on the website.

@weegeekps
Copy link
Contributor

@javagl I see all of the entries added by this PR on the site. I think this is likely a browser caching issue. Can you please try clearing your cache and confirm to me? If it is there is a quick solution we can implement.

@javagl
Copy link
Contributor

javagl commented Jun 29, 2020

Indeed, now they appear (but I have to admit that during my previous test, I entered "Protech" into the search bar, and that doesn't appear in the titles... so the issue was either entirely my fault, or due to caching ...).

Sorry for bugging you with these notifications.

@MonaliProtoTech The projects should now appear in http://github.khronos.org/glTF-Project-Explorer/ - for example, when searching for SolidEdge, it immediately shows your SolidEdge exporter project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants