-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0-dev.3.1 #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the upstream update to dart2js?
It's for |
I'm seeing a crash (in VSCode) or infinite loop (on Windows command line) for this invalid model:
This is an intentionally-damaged version of the glTF-Embedded/Box.gltf sample. It dates from 2017 and I'm sure it used to correctly produce validation errors at some point. |
This wasn't introduced with the patch, maybe with 3.0. I've just widened my testing process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested with VSCode, glTF-Sample-Models, and glTF-Blender-IO/tests.
I'm looking for a sample of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes look good. Tested with VSCode, glTF-Sample-Models, and a new KHR_mesh_quantization
sample.
Published to npm. |
A bugfix update for the recent
2.0.0-dev.3.0
release.New Features
Bugfixes
2.0.0-dev.3.0
).ARRAY_LENGTH_NOT_IN_LIST
for accessors of integer component type.ARRAY_LENGTH_NOT_IN_LIST
no longer reported for accessors of unknown type.2.0.0-dev.3.0
).2.0.0-dev.3.0
).