Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0-dev.3.1 #129

Merged
merged 10 commits into from
Jan 17, 2020
Merged

Version 2.0.0-dev.3.1 #129

merged 10 commits into from
Jan 17, 2020

Conversation

lexaknyazev
Copy link
Member

@lexaknyazev lexaknyazev commented Jan 10, 2020

A bugfix update for the recent 2.0.0-dev.3.0 release.

New Features

  • (CLI) When validating a directory, the validator now additionally lists assets with errors in the end (improves Sample-Models CI experience).
  • (CLI) Usage info and runtime errors are more accurate now.

Bugfixes

  • Fixed crash on unresolved node children used in a scene (introduced in 2.0.0-dev.3.0).
  • Fixed incorrect error message in ARRAY_LENGTH_NOT_IN_LIST for accessors of integer component type.
  • ARRAY_LENGTH_NOT_IN_LIST no longer reported for accessors of unknown type.
  • IBM and attribute accessor data is no longer validated when the accessors have invalid formats.
  • (CLI) Uncaught runtime errors no longer hang directory validation.
  • (CLI) Await until the report is written and flushed to disk (fixes Windows command-line build output #126).
  • (npm) Fixed crash on missing validation options JS object (introduced in 2.0.0-dev.3.0).
  • (npm) Fixed compatibility with Web Workers (was broken in 2.0.0-dev.3.0).

@lexaknyazev lexaknyazev marked this pull request as ready for review January 14, 2020 11:54
Copy link

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the upstream update to dart2js?

@lexaknyazev
Copy link
Member Author

Is the upstream update to dart2js?

It's for node_preamble dependency.

@emackey
Copy link
Member

emackey commented Jan 14, 2020

I'm seeing a crash (in VSCode) or infinite loop (on Windows command line) for this invalid model:

Busted_Box.zip

glTF Validator error: NoSuchMethodError: method not found: 'cn' on null

This is an intentionally-damaged version of the glTF-Embedded/Box.gltf sample. It dates from 2017 and I'm sure it used to correctly produce validation errors at some point.

@emackey
Copy link
Member

emackey commented Jan 14, 2020

This wasn't introduced with the patch, maybe with 3.0. I've just widened my testing process.

@lexaknyazev
Copy link
Member Author

@emackey
Thanks for a very good test asset. I've found a few more issues.
The crash is fixed in 6ce4afa.

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested with VSCode, glTF-Sample-Models, and glTF-Blender-IO/tests.

@emackey
Copy link
Member

emackey commented Jan 16, 2020

I'm looking for a sample of KHR_mesh_quantization (PR: KhronosGroup/glTF#1673, Sample wanted: KhronosGroup/glTF-Sample-Models#246), so I can test what happens when extensions add unexpected enum values for things like POSITION attribute data types.

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good. Tested with VSCode, glTF-Sample-Models, and a new KHR_mesh_quantization sample.

@lexaknyazev lexaknyazev merged commit ce91c66 into master Jan 17, 2020
@lexaknyazev lexaknyazev deleted the flush-io branch January 17, 2020 15:20
@emackey
Copy link
Member

emackey commented Jan 17, 2020

Published to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows command-line build output
4 participants