Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0-dev.3.4 #158

Merged
merged 9 commits into from
Jun 17, 2021
Merged

Version 2.0.0-dev.3.4 #158

merged 9 commits into from
Jun 17, 2021

Conversation

lexaknyazev
Copy link
Member

@lexaknyazev lexaknyazev commented Apr 13, 2021

2.0.0-dev.3.4

New Features

Bugfixes

  • Fixed incomplete JSON pointers for out-of-range array elements.

  • Web build is now usable from a local filesystem.

Integration updates

@lexaknyazev lexaknyazev added this to the 2.0 milestone Apr 13, 2021
@donmccurdy
Copy link
Contributor

One suggestion, otherwise changes look good!

Might be worthwhile to check for the (disallowed) combination of PBR Next extensions with KHR_materials_pbrSpecularGlossiness or KHR_materials_unlit.

There's also an interaction with volume and transmission...

The volume extension needs to be combined with an extension that allows light rays to pass through the surface into the volume, e.g. KHR_materials_transmission

... but perhaps no point in testing for that case until the translucency extension is also available.

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far. It will be great to have support for specular/ior/volume.

@lexaknyazev lexaknyazev requested a review from emackey June 16, 2021 15:45
@lexaknyazev lexaknyazev marked this pull request as ready for review June 16, 2021 15:46
@lexaknyazev lexaknyazev changed the title [WIP] Version 2.0.0-dev.3.4 Version 2.0.0-dev.3.4 Jun 16, 2021
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, glad to have variants added to the list too. Tested a couple things in VSCode, seems to work fine.

@lexaknyazev
Copy link
Member Author

@donmccurdy

Might be worthwhile to check for the (disallowed) combination of PBR Next extensions with KHR_materials_pbrSpecularGlossiness or KHR_materials_unlit.

Since the previous release, these two extensions get flagged when used with any other material extensions.

@lexaknyazev lexaknyazev merged commit 549b8b8 into master Jun 17, 2021
@lexaknyazev lexaknyazev deleted the dev branch June 17, 2021 08:49
@emackey
Copy link
Member

emackey commented Jun 17, 2021

I hope I didn't jump the gun here, but since this got merged, I published dev3.4 to NPM, built from commit 22a8b17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants