Include docs in archives & update notices #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lexaknyazev I suspect it's easier to bump the version number than it is to try to edit a published version on npm. |
|
The already published npm package is immutable. Do you think we should issue a new one just for this change? |
|
I think these are our options:
For the last two options we may choose to release a new npm package or to wait until the next release. |
|
I don't have a strong opinion. May as well bump to 3.5, just to keep the version numbering simple. |
|
PTAL |
emackey
approved these changes
Jun 23, 2021
|
@lexaknyazev Awesome. Let me know when the GitHub release tag is up, thanks! |
|
The release tag is up. This time, we also ship a precompiled binary for macOS and a copy of the hosted drag-n-drop tool in addition to Windows and Linux builds. |
|
This is published to NPM now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates 3rd-party licenses and ensures that all required docs are included in the generated archives.
@emackey
Do we need to re-publish the npm package?