Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0-dev.3.7 #181

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Version 2.0.0-dev.3.7 #181

merged 1 commit into from
Apr 28, 2022

Conversation

lexaknyazev
Copy link
Member

2.0.0-dev.3.7

New Features

  • Added GLB_EXTRA_DATA warning. Extra bytes beyond the declared GLB total length are now ignored.

Bugfixes

Integration updates

  • ZIP-archives generated on Windows can now be opened on other platforms.

@lexaknyazev lexaknyazev added this to the 2.0 milestone Apr 27, 2022
Copy link

@javagl javagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce issue #180 , but this apparently only happens in the web version? I'm not sure about the translation process from Dart to the minified JavaScript. The "desktop version" (before the fix) seems to work and create

{
    "uri": "test/base/data/glb/todo.glb",
    "mimeType": "model/gltf-binary",
    "validatorVersion": "2.0.0-dev.3.5",
    "issues": {
        "numErrors": 22310,
        "numWarnings": 22333,
...

with the input file that was given as a test case. (Speaking of test cases: I wondered whether there should be some glb-with-lots-of-zeros.glb as "unit test" for that, but maybe the extra_data.glb sufficiently covers this)

I don't know what happens in grind.dart in all detail, but at least can confirm that with the changes done there, dart run grinder exe-archive (still) works.

tool/grind.dart Show resolved Hide resolved
@lexaknyazev
Copy link
Member Author

I tried to reproduce issue #180, but this apparently only happens in the web version?

The crash happened because the web version limits the number of validation messages to 16384 and the GLB parser didn't have the proper exception handler for that. The crash should be reproducible with the desktop tool when given a config file. Adding integration tests is planned but not as a part of this release.

@emackey
Copy link
Member

emackey commented Apr 27, 2022

I haven't had a chance to test this one with my usual tests, but it looks like there are no major changes here, so I'm not expecting any problems from this. Thanks!

@lexaknyazev lexaknyazev removed the request for review from emackey April 28, 2022 05:54
@lexaknyazev lexaknyazev merged commit e3feece into main Apr 28, 2022
@lexaknyazev lexaknyazev deleted the dev branch April 28, 2022 05:54
@emackey
Copy link
Member

emackey commented Apr 29, 2022

Published to npm and VSCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants