Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0-dev.3.9 #191

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Version 2.0.0-dev.3.9 #191

merged 4 commits into from
Jun 23, 2022

Conversation

lexaknyazev
Copy link
Member

2.0.0-dev.3.9

Bugfixes

  • Fixed false positive ANIMATION_DUPLICATE_TARGETS caused by animation targets without node (Fix AnimationDuplicateTargets #190).

  • Fixed false positive ANIMATION_SAMPLER_OUTPUT_ACCESSOR_INVALID_COUNT caused by animation targets with unknown path.


/cc @hybridherbst

@lexaknyazev lexaknyazev requested a review from emackey June 17, 2022 09:06
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Question, when the path is a known value but the node is undefined, should that be a warning (or error?)

    "animations": [
        {
            "channels": [
                {
                    "sampler": 0,
                    "target": {
                        "path": "rotation"  // rotation of what? There's no "node" here.
                    }
                },

@lexaknyazev
Copy link
Member Author

This all looks good to me. Question, when the path is a known value but the node is undefined, should that be a warning (or error?)

When there are also no extensions, I think this should be a warning.

@lexaknyazev lexaknyazev merged commit f487744 into main Jun 23, 2022
@lexaknyazev lexaknyazev deleted the dev branch June 23, 2022 20:03
@emackey
Copy link
Member

emackey commented Jun 24, 2022

This is published to npm now (including #192 in this release).

@06wj
Copy link

06wj commented Jul 6, 2022

This way of merging wipes out my code contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants