Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup duck.json example #169

Closed
pjcozzi opened this issue Nov 1, 2013 · 5 comments
Closed

Cleanup duck.json example #169

pjcozzi opened this issue Nov 1, 2013 · 5 comments

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Nov 1, 2013

duck.json includes a buffer that points to a path that doesn't exist. Should we remove this?

        "duckcompression": {
            "byteLength": 0,
            "path": "duckcompression.bin",
            "type": "text"
        }
@fabrobinet
Copy link
Contributor

Sure. I'll clean this. Thanks

@pjcozzi
Copy link
Member Author

pjcozzi commented Nov 1, 2013

The converter outputs this by default without creating the binary file. This is an annoying bug for implementations that want to download the entire buffer at once to reduce requests instead of going through referenced buffer views.

@fabrobinet
Copy link
Contributor

Did you try building master tot ? I think it is already fixed. Anyhow I'll let you know once I get back tonight when I get back in front of my computer

@pjcozzi
Copy link
Member Author

pjcozzi commented Nov 1, 2013

Yes, I just built master.

@fabrobinet
Copy link
Contributor

Fixed on dev-2, but keeping around to update models once dev-2 is merged on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants