Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOINT_MATRIX or JOINTMATRIX? #187

Closed
pjcozzi opened this issue Nov 12, 2013 · 7 comments
Closed

JOINT_MATRIX or JOINTMATRIX? #187

pjcozzi opened this issue Nov 12, 2013 · 7 comments
Labels

Comments

@pjcozzi
Copy link
Member

pjcozzi commented Nov 12, 2013

The naming convention for JOINT_MATRIX is inconsistent with the rest of the uniform semantics in #83. However, they are inconsistent with WebGL naming conventions, e.g., FLOAT_VEC3.

We can:

  • Do nothing.
  • Change JOINT_MATRIX to JOINTMATRIX`.
  • Change the other semantics, e.g., MODELVIEWPROJECTION to MODEL_VIEW_PROJECTION

Perhaps the last option is best.

@fabrobinet
Copy link
Contributor

another option is just JOINT (since you know the type in the param)

@pjcozzi
Copy link
Member Author

pjcozzi commented Nov 12, 2013

another option is just JOINT (since you know the type in the param)

This is also OK with me, but the question still remains for names of semantics, e.g., MODELVIEWPROJECTION vs. MODEL_VIEW_PROJECTION.

@fabrobinet
Copy link
Contributor

I personally prefer MODELVIEWPROJECTION maybe because of the precedent in GL which was GL_MODELVIEW and not GL_MODEL_VIEW - So I am more used to it, but not feeling too strongly about it either...

@pjcozzi
Copy link
Member Author

pjcozzi commented Mar 6, 2014

I am OK with keeping no underscores (e.g., MODELVIEWPROJECTION) and renaming JOINT_MATRIX to JOINTMATRIX (there is already a JOINT attribute).

@fabrobinet do you agree? If so I will update the schema for JOINTMATRIX.

@fabrobinet
Copy link
Contributor

I agree. consistency first no underscores.... + flagged for converter

@pjcozzi pjcozzi mentioned this issue Mar 7, 2014
10 tasks
@pjcozzi
Copy link
Member Author

pjcozzi commented Mar 7, 2014

Schema is updated. b20d1cf

@pjcozzi
Copy link
Member Author

pjcozzi commented Aug 27, 2015

The schema and the converter are updated.

@pjcozzi pjcozzi closed this as completed Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants