Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema updates #241

Closed
wants to merge 78 commits into from
Closed

Schema updates #241

wants to merge 78 commits into from

Conversation

pjcozzi
Copy link
Member

@pjcozzi pjcozzi commented Feb 26, 2014

This is a pull request from the schema branch to a new spec branch where I will make spec changes (maybe in time for GDC, no promises though!). Once the schema and spec are synced, I'll open another pull request to merge spec to master.

This brings the JSON schema up-to-date with the glTF JSON produced by the converter in master. This still needs a few things before merging.

There are several issues open with the specification label, but we don't need to address all of them right away. I am more concerned about getting the schema in sync with the converter and then keeping them in sync.

We will also have a small open-source JavaScript library that takes a root glTF object and adds missing properties that have default values, e.g., use identity if matrix.node and TRS properties are undefined. This will make it easy to work with the converter option that excludes properties set to their default values. The source is currently here, but it needs more testing and to be moved to its own repo.

@denisjarus
Copy link

Captain obvious here, noting that a single tab used for indentation in some of these changes, while the original code uses four spaces.

@pjcozzi pjcozzi mentioned this pull request Mar 19, 2014
@pjcozzi pjcozzi added this to the Draft 1.0 spec milestone Apr 30, 2014
@fabrobinet
Copy link
Contributor

@pjcozzi do you think you can you merge this PR this week ?

@pjcozzi
Copy link
Member Author

pjcozzi commented Jul 24, 2014

No, it will be the week of August 4 given the August 1 Cesium release.

@pjcozzi
Copy link
Member Author

pjcozzi commented Aug 9, 2014

@fabrobinet I am closing this and will re-open a PR from schema-8 shortly - I just need to tweak the render states and read over the README.md.

@pjcozzi pjcozzi closed this Aug 9, 2014
@fabrobinet
Copy link
Contributor

ok @pjcozzi thanks for the heads up and the hard work on that one

@pjcozzi pjcozzi mentioned this pull request Aug 9, 2014
@pjcozzi pjcozzi deleted the schema branch April 22, 2015 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants